Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of SOSDacApi GetMethodDescName for cDAC #106169

Merged
merged 43 commits into from
Aug 13, 2024

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    255da99 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Move metadata reader into helpers

    Add implementations for changes to RuntimeTypeSystem contract
    Add SOSDacInterface call into cDac for GetMethodTableName
    davidwrighton committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0671cd4 View commit details
    Browse the repository at this point in the history
  2. Simplify storage of saved metadata copy for reflection emit scenarios

    - Move pointer to Module class
    - Replace use of SBuffer abstraction with a simple counted byte memory block
    Add metadata details to Loader contract
    Add Metadata helper api for use by contracts within the cDAC (and possibly clients of cDAC too)
    davidwrighton committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    636bb2b View commit details
    Browse the repository at this point in the history
  3. Fix bugs found when trying to actually use this logic

    1. It works now!
    davidwrighton committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d359ed9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc24cd4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d93e98b View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Feedback

    davidwrighton committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fead409 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    d2b36fc View commit details
    Browse the repository at this point in the history
  2. - Refactor to expose TypeHandle exclusively from the contracts

    - Remove TypeHandleArray and MethodTableArray in favor of contract specific logic
    davidwrighton committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8fdcc24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    30da32c View commit details
    Browse the repository at this point in the history
  4. Merge branch 'cdac-methodtable-name' of github.com:davidwrighton/runt…

    …ime into cdac-methodtable-name
    davidwrighton committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    87f7003 View commit details
    Browse the repository at this point in the history
  5. Fix build break

    davidwrighton committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    143cb86 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Fix musl build issue

    davidwrighton committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7284f83 View commit details
    Browse the repository at this point in the history
  2. Cherrypick RuntimeTypeSystem changes from dotnet#104759

    Co-Authored-By: David Wrighton <davidwr@microsoft.com>
    lambdageek and davidwrighton committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2d5ec4f View commit details
    Browse the repository at this point in the history
  3. update tests

    lambdageek committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8e2dbca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e3964f9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    38d0a51 View commit details
    Browse the repository at this point in the history
  6. wip: MethodDesc

    lambdageek committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9d88f19 View commit details
    Browse the repository at this point in the history
  7. add MethodDescChunk

    lambdageek committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4a4c3a4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    510a10f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    419cb11 View commit details
    Browse the repository at this point in the history
  10. update contract

    lambdageek committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1321aa9 View commit details
    Browse the repository at this point in the history
  11. fix RuntimeTypeSystem unit tests

    mock the additional data and globals
    lambdageek committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dcc4540 View commit details
    Browse the repository at this point in the history
  12. update contract

    lambdageek committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c31bdcf View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7517e32 View commit details
    Browse the repository at this point in the history
  14. update tests

    lambdageek authored and davidwrighton committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    54ab23e View commit details
    Browse the repository at this point in the history
  15. fixup rebase

    lambdageek committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    27fcddc View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2a41206 View commit details
    Browse the repository at this point in the history
  17. - Transform magic numbers from DacStreams implementation into constants

    - Add test suite for the DacStreams contract
    davidwrighton committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dbe3cf4 View commit details
    Browse the repository at this point in the history
  18. Feedback

    davidwrighton committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3a35f41 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    1eb3b36 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    785ced4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    01d3d24 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b6b6fd View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    0c7a254 View commit details
    Browse the repository at this point in the history
  2. Commit current state

    davidwrighton committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ec9eb54 View commit details
    Browse the repository at this point in the history
  3. It Works!

    davidwrighton committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    54ded9a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ffb03b View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Handle Path fallback scenario. Leave actual implementation/documentat…

    …ion of contract Loader.GetPath for a future date
    davidwrighton committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e72cea6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c250bb8 View commit details
    Browse the repository at this point in the history
  3. Address code review comments

    1. Rename mcNDirect to mcPInvoke
    2. Rename MethodDescClassification to MethodClassification
    3. Remove mc prefix from all MethodClassification enum values
    4. Move handling of various forms of MethodDescs to using an AsBlah method, and handle the flags in those methods, to make the actual contract methods somewhat simpler.
    5. Compute the token eagerly on MethodDesc creation to avoid having to hold a pointer to the Target
    davidwrighton committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c3ebfdb View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Configuration menu
    Copy the full SHA
    bcf9fba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de846a5 View commit details
    Browse the repository at this point in the history