-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HttpClientFactory] Don't log header values by default #106271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only concern is about performance, but I suppose in default we do not log header values so by default perf is not affected by redacting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we treating this as a breaking change?
src/libraries/Microsoft.Extensions.Http/src/Logging/LogHelper.cs
Outdated
Show resolved
Hide resolved
...nsions.Http/tests/Microsoft.Extensions.Http.Tests/Logging/RedactedLogValueIntegrationTest.cs
Outdated
Show resolved
Hide resolved
...nsions.Http/tests/Microsoft.Extensions.Http.Tests/Logging/RedactedLogValueIntegrationTest.cs
Outdated
Show resolved
Hide resolved
...nsions.Http/tests/Microsoft.Extensions.Http.Tests/Logging/RedactedLogValueIntegrationTest.cs
Outdated
Show resolved
Hide resolved
...nsions.Http/tests/Microsoft.Extensions.Http.Tests/Logging/RedactedLogValueIntegrationTest.cs
Outdated
Show resolved
Hide resolved
...nsions.Http/tests/Microsoft.Extensions.Http.Tests/Logging/RedactedLogValueIntegrationTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@rokonec yeah, these are
@MihaZupan Yes, we should; there is some tag I need to apply here then, right? |
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
/ba-g DeadLetter Helix crash on an unrelated test run (System.Runtime.Tests on ios-arm64) |
Only affects the default case; if the sensitive headers were ever specified by
RedactLoggedHeaders
, the behavior is unchanged.