Update dispose async test timeout and better diagnostics #106272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
added
test-bug
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection |
steveharter
commented
Aug 12, 2024
|
|
||
| Assert.True(doesNotHang); | ||
| Assert.True(asyncDisposableResource.DisposeAsyncCalled); | ||
| Assert.True(doesNotHang, "!doesNotHang"); |
There was a problem hiding this comment.
To verify which Assert.True is actually failing.
steveharter
commented
Aug 12, 2024
| @@ -392,10 +392,10 @@ public void GetAsyncService_DisposeAsyncOnSameThread_ThrowsAndDoesNotHangAndDisp | |||
| var service = sp.GetRequiredService<DisposeServiceProviderInCtorAsyncDisposable>(); | |||
| }); | |||
| }); | |||
| }).Wait(TimeSpan.FromSeconds(10)); | |||
| }).Wait(TimeSpan.FromSeconds(20)); | |||
There was a problem hiding this comment.
To help determine if the test is timing out; likely this will be reverted.
ericstj
approved these changes
Aug 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help diagnose #104041.