ARM64-SVE: Emit AddSequentialAcross correctly
#106292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
This was referenced Aug 12, 2024
a74nh
reviewed
Aug 13, 2024
| emitDispReg(id->idReg1(), size, true); // ddddd | ||
| emitDispLowPredicateReg(id->idReg2(), insGetPredicateType(fmt), id->idInsOpt(), true); // ggg | ||
| emitDispReg(id->idReg1(), size, true); // ddddd | ||
| emitDispSveReg(id->idReg3(), id->idInsOpt(), false); // mmmmm | ||
| break; | ||
|
|
||
| // <V><dn>, <Pg>, <V><dn>, <Zm>.<T> | ||
| case IF_SVE_HJ_3A: // ........xx...... ...gggmmmmmddddd -- SVE floating-point serial reduction (predicated) |
There was a problem hiding this comment.
I'm surprised this was never caught in the codegen testing. Although it's possible something else changed around it.
There was a problem hiding this comment.
Yeah, I imagine this was refactored at some point after it was first implemented
|
@TIHan can you PTAL? Thanks! |
|
@TIHan, @dotnet/arm64-contrib, please review this PR before RC1 snap. |
TIHan
approved these changes
Aug 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106180.
AddSequentialAcrossnow looks like this in JIT disasms:We no longer emit
movprfx, and the destination SIMD register is printed correctly (I think this is everything we needed to fix for this intrinsic). I also found a couple of other nearby instruction formats that needed to be fixed inemitDispInsSveHelp.AddSequentialAcrossstress tests are passing. @dotnet/arm64-contrib PTAL, thanks!