-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SafeEvpPKeyHandle.OpenKeyFromProvider throw PNSE on OSSL less than 3.0 #106397
Conversation
...s/System.Security.Cryptography/src/System/Security/Cryptography/SafeEvpPKeyHandle.OpenSsl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs
Outdated
Show resolved
Hide resolved
src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey.h
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
/backport to release/9.0-rc1 |
Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10486290096 |
/backport to release/9.0-rc2 |
Started backporting to release/9.0-rc2: https://github.com/dotnet/runtime/actions/runs/10487089426 |
@krwq an error occurred while backporting to release/9.0-rc2, please check the run log for details! Error: The specified backport target branch release/9.0-rc2 wasn't found in the repo. |
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10487129178 |
Fixes: #105175
Description:
default
provider - they're not as comprehensive as existing manual tests because losing info about provider from SafeEvpPKeyHandle will not cause them to fail (this is becauseNULL
is equivalent todefault
provider so they may accidentally pass) - they will exercise the new logic in the DuplicateHandle and other places in the automated tests