-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObjWriter/Mach-O] Mark non-global symbols as .private_extern to match ELF #106446
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
/azp run runtime-nativeaot-outerloop, runtime-extra-platforms |
Azure Pipelines successfully started running 2 pipeline(s). |
Cc @ivanpovazan @dotnet/jit-contrib @dotnet/ilc-contrib for Apple-specific ObjWriter change. Looks reasonable to me but don't know much about Apple stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@filipnavara I assume that we do not need to backport this fix to .NET 9. Correct?
Correct. I don't see a need to backport it at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Extracted from #106224
.private_extern
is the logical equivalent of.hidden
+.global
in ELF. We already emit those flags in ELF, so do it in Mach-O too.Documentation for
.private_extern
: