[feature/9.0-cdac-backports] Data descriptor changes for GetMethodDescName #106463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrecodeMachineDescriptor::Init() will initialize g_PrecodeMachineDescriptor
|
Tagging subscribers to this area: @tommcdon |
25 tasks
lambdageek
commented
Aug 15, 2024
| @@ -332,7 +332,7 @@ class LoaderAllocator | |||
| bool m_fTerminated; | |||
| bool m_fMarked; | |||
| int m_nGCCount; | |||
| bool m_IsCollectible; | |||
| BYTE m_IsCollectible; | |||
There was a problem hiding this comment.
I couldn't make this const BYTE because that created build errors in the DAC-ize constructor created by the VPTR_BASE_VTABLE_CLASS(LoaderAllocator) macro
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
need to update the yml on the main branch to allow runtime/eng/pipelines/runtime.yml Lines 38 to 40 in cef3898 |
6 tasks
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #99302
Some changes extracted from #106169 that should be backported to 9.0 when we're ready
Note this is targeting the
feature/9.0-cdac-backportsbranch, notrelease/9.0. The cdac related changes will go into the net9.0 release at a later timeTODO:
NDirect->PInvokein descriptor