Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MethodTable::IsDynamicStatics and DacpMethodTableData::bIsDynamic to return 0/1 instead of flag value #106504

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Update MethodTable::IsDynamicStatics and DacpMethodTableData::bIsDynamic to return 0/1 instead of flag value #106504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd17e47
Update assert in GetMethodTableData for cDAC/DAC bIsDynamic values
elinor-fung Aug 15, 2024
2f649b8
Make DAC return TRUE/FALSE instead of flag value for DacpMethodTableD…
elinor-fung Aug 15, 2024
c0666d0
Make MethodTable::IsDynamicStatics return 0/1 instead of flag value
elinor-fung Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/debug/daccess/request.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2160,7 +2160,7 @@ ClrDataAccess::GetMethodTableDataImpl(CLRDATA_ADDRESS mt, struct DacpMethodTable
MTData->dwAttrClass = pMT->GetAttrClass();
MTData->bContainsPointers = pMT->ContainsGCPointers();
MTData->bIsShared = FALSE;
MTData->bIsDynamic = pMT->IsDynamicStatics();
MTData->bIsDynamic = pMT->IsDynamicStatics() ? TRUE : FALSE;
}
return S_OK;
}
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/vm/methodtable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2567,10 +2567,10 @@ class MethodTable
inline PTR_BYTE GetNonGCThreadStaticsBasePointer(PTR_Thread pThread);
inline PTR_BYTE GetGCThreadStaticsBasePointer(PTR_Thread pThread);

inline DWORD IsDynamicStatics()
inline BOOL IsDynamicStatics()
{
LIMITED_METHOD_DAC_CONTRACT;
return GetFlag(enum_flag_DynamicStatics);
return GetFlag(enum_flag_DynamicStatics) == enum_flag_DynamicStatics;
}

inline void SetDynamicStatics()
Expand Down