[release/9.0] Update MethodTable::IsDynamicStatics and DacpMethodTableData::bIsDynamic to return 0/1 instead of flag value
#106643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @tommcdon |
mikem8361
approved these changes
Aug 19, 2024
hoyosjs
approved these changes
Aug 19, 2024
This was referenced Aug 19, 2024
|
/ba-g System.IO known failure (out of memory in test process) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106504 to release/9.0
/cc @elinor-fung
Customer Impact
A DAC API inadvertently started returning something other than 0/1 for a value representing a bool - it would return the value of a flag to represent true. This is behaviour that is different from previous and future versions and not something we want anyone to start relying on.
Regression
eb8f54d
Testing
Manual testing, asserts.
Risk
Low. This simply explicitly returns 0/1 as a bool value instead of a non-zero to represent true.