-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] Fix stack overflow in the configuration source gen #106668
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for RC2. Reliability issue that we'd service for.
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Build had the failure due to ILC problem. Rerunning to ensure we get a complete build. |
Backport of #106511 to release/9.0
/cc @ericstj @tarekgh
Customer Impact
When using the configuration source generator on a type that has a cycle in it's generic parameter the source generator will crash with a stack overflow, eg:
Regression
Testing
Validated customer reported type, unit tests added.
Risk
Low, only impacts users of source generator and only paths where we inspect element types.