Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Fix stack overflow in the configuration source gen #106668

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 19, 2024

Backport of #106511 to release/9.0

/cc @ericstj @tarekgh

Customer Impact

  • Customer reported

When using the configuration source generator on a type that has a cycle in it's generic parameter the source generator will crash with a stack overflow, eg:

public sealed class TreeElement : Dictionary<string, TreeElement>;

Regression

  • No

Testing

Validated customer reported type, unit tests added.

Risk

Low, only impacts users of source generator and only paths where we inspect element types.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for RC2. Reliability issue that we'd service for.

@ericstj ericstj added the Servicing-approved Approved for servicing release label Aug 22, 2024
@ericstj
Copy link
Member

ericstj commented Aug 22, 2024

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ericstj
Copy link
Member

ericstj commented Aug 22, 2024

Build had the failure due to ILC problem. Rerunning to ensure we get a complete build.

@ericstj ericstj merged commit 5ec43e0 into release/9.0 Aug 23, 2024
85 checks passed
@jkotas jkotas deleted the backport/pr-106511-to-release/9.0 branch August 24, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants