Remove unused custom marshaler code and move ICustomMarshaler and Color marshalling handling to managed code #106735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he checks outside of the exception path.
… the indirection into the stub helper)
…code as much as possible.
This was referenced Aug 21, 2024
…and remove a box->unbox->box operation sequence
jkotas
reviewed
Aug 23, 2024
This was referenced Aug 24, 2024
jkotas
approved these changes
Aug 27, 2024
jkotas
reviewed
Aug 28, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…or marshalling handling to managed code (dotnet#106735)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove complexity and layering in custom marshaler code now that
SharedCustomMarshalerHelperis unused. Reuse some of theICustomMarshalerhelpers in StubHelpers for allICustomMarshalerusage.Move
IEnumeratorandSystem.Drawing.Colormarshalling helpers into StubHelpers to remove assembly-qualified name lookup and non-corelib type lookup from the runtime.