Added additional tests for generic attributes. #106745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a test for GetCustomAttribute to verify that the values of the generic type are correctly initialized. - Added some theory data to check the equality of generic attributes. Fixes dotnet#73735
dotnet-policy-service
bot
added
the
community-contribution
buyaa-n
reviewed
Aug 23, 2024
| } | ||
|
|
||
| [Fact] | ||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/56887", TestRuntimes.Mono)] |
There was a problem hiding this comment.
Looks #56887 is resolved, could you please remove all the [ActiveIssue("https://github.com/dotnet/runtime/issues/56887", TestRuntimes.Mono)]?
This was referenced Aug 26, 2024
Open
|
@buyaa-n It looks like |
…e test is still failing on Mono.
buyaa-n
reviewed
Aug 28, 2024
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Attributes.cs
Outdated
Show resolved
Hide resolved
Yep, I filed a new issue for that and updated the attribute, thanks! |
3 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* Added additional tests for generic attributes. - Added a test for GetCustomAttribute to verify that the values of the generic type are correctly initialized. - Added some theory data to check the equality of generic attributes. Fixes dotnet#73735 * Removed active issue attribute for solved issue 56887. * Added active issue attribute for solved issue dotnet#56887 because the test is still failing on Mono. * Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Attributes.cs --------- Co-authored-by: Stefan König <stefan.koenig@zuehlke.com> Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73735