[release/9.0] Fix trimming for DiagnosticSource #106842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Recent changes to EventSource startup caused the IL trimmer to include portions of the DiagnosticSource assembly. Adding the IsMeterSupported feature check wasn't sufficient because EventSource also roots all of its methods via a DynamicallyAccessedMembers attribute. To ensure that the new methods can be removed when needed I refactored them into a separate EventSourceInitHelper class that won't be rooted by the existing DAM attribute. When EventSouce.IsSupported is false I'd expect the entire EventSourceInitHelper class to be unreachable. If only EventSource.IsMeterSupported is false then I'd expect PreregisterEventProviders and GetMetricsEventSource() to be unreachable but the rest of the class will remain. Hopefully this really fixes #106265 this time.
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti |
jeffschwMSFT
approved these changes
Aug 22, 2024
|
@vitek-karas - could you approve this one as well? It should be unmodified from what you saw in the 10.0 branch. |
vitek-karas
approved these changes
Aug 23, 2024
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106680 to release/9.0
/cc @noahfalk
Customer Impact
A recent change caused a binary size regression for HelloWorld on Mono (Issue #106265).
Regression
Introduced in #106014
Testing
@vitek-karas confirmed the size had returned to normal looking at automated perf results. It was missed initially because perf testing doesn't occur automatically prior to PR merge and I didn't recognize the impact it would have on the IL linked binaries.
Risk
Low - the change executes exactly the same logic as before with some refactorings applied: