Fix object.GetType dataflow edge case #106909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
3 tasks
jtschuster
approved these changes
Aug 26, 2024
This was referenced Aug 27, 2024
|
/ba-g "timeouts" |
sbomer
added a commit
that referenced
this pull request
Aug 28, 2024
The equality check needs to determine whether two TypeProxy instances represent the same type. The check was incorrect when two different object instances were allocated to represent the same generic instantiated type. ILCompiler doesn't have this problem because it uses a cache to ensure that the same object instance represents a given instantiated generic type. Discovered while investigating #106215, see more context at #106215 (comment). The new testcase also uncovered an issue in the analyzer that was fixed in #106909.
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
Partial fix for one of the cases mentioned in dotnet#106886. This moves some of the tests to ObjectGetTypeDataflow.cs because ObjectGetType.cs is skipped by native AOT. Fixes an issue discovered while investigating dotnet#106215.
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
The equality check needs to determine whether two TypeProxy instances represent the same type. The check was incorrect when two different object instances were allocated to represent the same generic instantiated type. ILCompiler doesn't have this problem because it uses a cache to ensure that the same object instance represents a given instantiated generic type. Discovered while investigating dotnet#106215, see more context at dotnet#106215 (comment). The new testcase also uncovered an issue in the analyzer that was fixed in dotnet#106909.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for one of the cases mentioned in #106886.
I moved some of the tests to ObjectGetTypeDataflow.cs because ObjectGetType.cs is skipped by native AOT. Fixes an issue I ran into while investigating #106215.