[release/9.0] JIT: Fix CndSel(AllTrue, op2, op3) -> op2 "next" node return
#106971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When lowering makes this transformation it should proceed lowering from the original next node of the `CndSel`, not from `op2`. If we proceed lowering from `op2` we will relower some nodes. Fix #106876
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jeffschwMSFT
approved these changes
Aug 26, 2024
amanasifkhalid
approved these changes
Aug 26, 2024
This was referenced Aug 26, 2024
|
Not sure why build analysis is red. All the failures it lists are known issues. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106954 to release/9.0
/cc @jakobbotsch
Customer Impact
Use of
System.Runtime.Intrinsics.Arm.Sve.ConditionalSelectwith certain patterns of arguments will cause the JIT to produce invalid internal IR and lead to unpredictable results (JIT crashes or silent bad codegen).Regression
Testing
A test case demonstrating the issue was found by Fuzzlyn, and the same test case was manually used to validate the fix.
Risk
Low.