Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend timeout when waiting for service status #106998

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Extend timeout when waiting for service status #106998

merged 1 commit into from
Aug 28, 2024

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Aug 26, 2024

Fix #103548

Wait for up to 3 minutes for the service status to change.

These tests were timing out in the JIT stress pipeline. Give them more time for the service to start up before failing.

cc @JulieLeeMSFT @mikelle-rogers

@ericstj
Copy link
Member Author

ericstj commented Aug 26, 2024

Probably any test that starts up another process (Remote Executor, service, etc) is going to be slow in these pipelines. IIUC they are forcing the JIT to do more work which I can imagine will cause problems at process startup. Most of our tests don't measure process startup since they are already running in the xunit host, but some like this launch a new process.

@ericstj
Copy link
Member Author

ericstj commented Aug 28, 2024

Helix was backed up, things seem to be working now. Hopefully this will pass and make it in.

@ericstj ericstj merged commit 6f80da6 into main Aug 28, 2024
84 checks passed
@ericstj
Copy link
Member Author

ericstj commented Aug 28, 2024

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10604241678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Microsoft.Extensions.Hosting.UseWindowsServiceTests.CanCreateService
3 participants