Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Helper Method Frames from debugdebugger #107058

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

Each commit contains a single functions from the diagnostic space. This PR is best reviewed by each commit.

Removed unused JIT Helper for x86.

Ran diagnostics tests and confirmed no failures.

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

src/coreclr/vm/debugdebugger.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/debugdebugger.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/debugdebugger.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/debugdebugger.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/debugdebugger.cpp Outdated Show resolved Hide resolved
@AaronRobinsonMSFT
Copy link
Member Author

@dotnet/dotnet-diag and @jkotas All green.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 2e7ee69 into dotnet:main Aug 29, 2024
90 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the hmf_x86_debug branch August 29, 2024 03:48
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
* Remove unused AllocObjectWrapper helper for x86.

* Convert Debugger.Break()

* Convert Debugger.CustomNotification()

* Convert StackTrace.GetStackFramesInternal()
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants