Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Ensure the layout of StackAllocatedBox<T> matches boxed layouts #107075

Merged
merged 5 commits into from
Aug 29, 2024

Commits on Aug 28, 2024

  1. Ensure the layout of StackAllocatedBox<T> matches boxed layouts

    The boxed layout of a struct always has its data at +8, as evidenced by
    `Object::UnBox`. This means that `StackAllocatedBox<T>` should have
    `Pack = 1`, otherwise this may not be the case. In the test failure we
    had a `StackAllocatedBox<Int128>` which had its `_value` field at offset
    16. After object stack allocation this meant that we were saving data in
    padding of the structure, which promotion does not guarantee to
    preserve.
    
    Fix #106947
    jakobbotsch authored and github-actions committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e9b552e View commit details
    Browse the repository at this point in the history
  2. Run jit-format

    jakobbotsch authored and github-actions committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ecfa62e View commit details
    Browse the repository at this point in the history
  3. Correct enum

    jakobbotsch authored and github-actions committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    52fd08e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    69dba4b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    2674cc1 View commit details
    Browse the repository at this point in the history