Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Upgrade vendored Brotli dependency to v1.1.0 #107102

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jkoritzinsky
Copy link
Member

Backport of #106994 to 9.0.

We want to be on the most recent release of Brotli for .NET 9.

See #106887

@carlossanlop can you get M2 approval from your side?

@jkoritzinsky
Copy link
Member Author

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10602606754

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member

@jkoritzinsky there was a patch in the main PR in a separate commit: https://github.com/dotnet/runtime/pull/106994/commits

@jkotas do we care to have the commits split in this PR like you requested in my zlib-ng update?

@artl93 artl93 added the Servicing-approved Approved for servicing release label Sep 5, 2024
@jkoritzinsky
Copy link
Member Author

@carlossanlop I included those changes into the initial commit in this PR.

@jkotas
Copy link
Member

jkotas commented Sep 5, 2024

do we care to have the commits split in this PR like you requested in my zlib-ng update?

This does not have any custom patches that have not been upstreamed, and the changes outside the vendored Brotli are very minimal. I do not have a problem with it all being in one commit.

@carlossanlop
Copy link
Member

/ba-g Re-ran failed CI legs and they passed. Only one known/pre-existing failure showed up.

@carlossanlop carlossanlop merged commit ee46f01 into dotnet:release/9.0 Sep 5, 2024
160 of 165 checks passed
@jkoritzinsky jkoritzinsky deleted the brotli-upgrade-9.0 branch September 5, 2024 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants