SPMI: Always enable venv for coreclr_tests.run collection #107133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise if the Helix run failed (because of a failing test) we won't run this step, which will cause the next steps to fail. This is currently happening for collections internally. The other places where we enable Python venv already have this `condition: always()`.
dotnet-issue-labeler
bot
added
the
needs-area-label
jakobbotsch
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Aug 29, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
|
cc @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise if the Helix run failed (because of a failing test) we won't run this step, which will cause the next steps to fail. This is currently happening for collections internally. The other places where we enable Python venv already have this
condition: always().