Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Ensure that Vector128.CreateSequence works on x86 for non-constant 64-bit inputs #107147

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2024

Backport of #107053 to release/9.0

/cc @tannergooding

Customer Impact

  • Customer reported
  • Found internally

Found by Antigen: #106372

Developers using the new vector CreateSequence API for long or ulong on an x86 machine would see incorrect results.

Regression

  • Yes
  • No

This is a new API in .NET 9 and a scenario that was missed for non-constant inputs on 32-bit hardware.

Testing

An explicit regression test was added and additional code paths were checked to ensure they were correctly handling the inputs.

Risk

Low. This is a net new API in .NET 9 and is simply falling back to the managed code path for 32-bit hardware, as expected.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 29, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member

CC. @dotnet/jit-contrib, @EgorBo

@tannergooding
Copy link
Member

Closed and reopened to get CI to start, its going now

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can merge when ready

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Aug 29, 2024
@jeffschwMSFT
Copy link
Member

@tannergooding can you take a look at the PR failures?

@tannergooding
Copy link
Member

@jeffschwMSFT, they are unrelated flaky tests and passed on rerun. -- They are variations of the general exit code 137 failure that has several tracking issues already (https://github.com/dotnet/runtime/issues?q=is%3Aissue+is%3Aopen+exit+code+137+)

@jeffschwMSFT jeffschwMSFT merged commit d4bce38 into release/9.0 Sep 4, 2024
10 of 16 checks passed
@tannergooding tannergooding deleted the backport/pr-107053-to-release/9.0 branch September 4, 2024 21:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants