-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] Ensure that Vector128.CreateSequence works on x86 for non-constant 64-bit inputs #107147
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
CC. @dotnet/jit-contrib, @EgorBo |
Closed and reopened to get CI to start, its going now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can merge when ready
@tannergooding can you take a look at the PR failures? |
@jeffschwMSFT, they are unrelated flaky tests and passed on rerun. -- They are variations of the general |
Backport of #107053 to release/9.0
/cc @tannergooding
Customer Impact
Found by Antigen: #106372
Developers using the new vector
CreateSequence
API forlong
orulong
on an x86 machine would see incorrect results.Regression
This is a new API in .NET 9 and a scenario that was missed for non-constant inputs on 32-bit hardware.
Testing
An explicit regression test was added and additional code paths were checked to ensure they were correctly handling the inputs.
Risk
Low. This is a net new API in .NET 9 and is simply falling back to the managed code path for 32-bit hardware, as expected.