[release/9.0] Fix bug in validating unused bits #107321
Merged
+58
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ase64Url/Base64UrlValidator.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
|
Tagging subscribers to this area: @dotnet/area-system-memory |
artl93
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106771 to release/9.0
/cc @buyaa-n
Customer Impact
The bug found with Base64Url fuzzer, regression introduced in preview 7 with validating unused bits PR.
Regression
Regression introduced with Base 64 decoder, reject input when unused bits are not 0, in new
Base64Urlvalidator APITesting
Unit tests that reproes the failure added, fuzz testing run again with the PR successfully
Risk
Low, the fix fully refactored existing logic to make the intended behavior more clear and efficient. Unit + fuzz tested.