Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.0.6613.120 #107504

Merged
merged 12 commits into from
Sep 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2024

  • Set options.setPageLoadStrategy(PageLoadStrategy.NONE); - selenium returns immediately when the page content is downloaded, opposed to waiting for a full load by default (PageLoadStrategy.NORMAL) (or at least PageLoadStrategy.EAGER - Selenium waits for DOM content) for WasmBuildTests on Windows and LibraryTest on Windows.
  • Adding --disable-gpu that could contribute to timeouts.

Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy self-assigned this Sep 9, 2024
@ilonatommy
Copy link
Member

Failing with #107466, even after dotnet/xharness#1261.

@ilonatommy
Copy link
Member

Still failing with timeouts. @pavelsavara had an idea that we could try to add to add more flags to chrome, like --disable-gpu, options.setPageLoadStrategy(PageLoadStrategy.NONE); - selenium returns immediately when the page content is downloaded, opposed to waiting for a full load by default (PageLoadStrategy.NORMAL) (or at least PageLoadStrategy.EAGER - Selenium waits for DOM content). I'll create another PR on xharness to check it out.

@ilonatommy
Copy link
Member

It helped, we can see that the last build has no WBT failures on Windows, where the fix was used but Lib tests still fail - we did not add the PageLoadStrategy.NONE there yet

@ilonatommy
Copy link
Member

/ba-g failures are #108019.

@ilonatommy ilonatommy merged commit 51bd2b9 into main Sep 19, 2024
37 of 41 checks passed
@jkotas jkotas deleted the update-chrome-version-10755397283 branch September 21, 2024 05:22
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
…0.6613.120 (dotnet#107504)

* Automated bump of chrome version

* Addning new `BrowserArguments` is possible without changes on xharness side.

* Add `--disable-gpu` to lib tests as well.

* Set `PageLoadStrategy=NONE` for browser on Windows to avoid timeouts in driver-browser communication.

* Remove whitespace.

* Set the fixing flag for lib tests on Windows.

* Fix: add args to chrome scenario, not node.

* Move appended WBT args to one place.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants