-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.0.6613.120 #107504
Conversation
Tagging subscribers to this area: @directhex, @matouskozak |
Failing with #107466, even after dotnet/xharness#1261. |
Still failing with timeouts. @pavelsavara had an idea that we could try to add to add more flags to chrome, like |
…in driver-browser communication.
It helped, we can see that the last build has no WBT failures on Windows, where the fix was used but Lib tests still fail - we did not add the |
/ba-g failures are #108019. |
…0.6613.120 (dotnet#107504) * Automated bump of chrome version * Addning new `BrowserArguments` is possible without changes on xharness side. * Add `--disable-gpu` to lib tests as well. * Set `PageLoadStrategy=NONE` for browser on Windows to avoid timeouts in driver-browser communication. * Remove whitespace. * Set the fixing flag for lib tests on Windows. * Fix: add args to chrome scenario, not node. * Move appended WBT args to one place. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com>
options.setPageLoadStrategy(PageLoadStrategy.NONE);
- selenium returns immediately when the page content is downloaded, opposed to waiting for a full load by default (PageLoadStrategy.NORMAL) (or at least PageLoadStrategy.EAGER - Selenium waits for DOM content) forWasmBuildTests
on Windows andLibraryTest
on Windows.--disable-gpu
that could contribute to timeouts.