Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Revert "don't define HAS_CUSTOM_BLOCKS on mono (#106764)" #107558

Conversation

matouskozak
Copy link
Member

This reverts commit 7266021. The commit caused significant improvements for MonoJIT but introduced unexpected regressions for MonoAOT/MonoInterpreter described at #107308 (comment).

We need to make a proper fix for MonoJIT #106822 to mitigate the regressions from dotnet/perf-autofiling-issues#33182.

This needs to be backport to .NET 9 because of #106801.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

@matouskozak matouskozak merged commit b8d7ec0 into dotnet:main Sep 11, 2024
144 of 148 checks passed
@matouskozak
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10807531453

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@matouskozak matouskozak deleted the revert-7266021f0e16011c38686618b73f0eb8e37f1644 branch October 3, 2024 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants