[release/9.0] Arm: Fix the base register used for restoring register from stack #107584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
BruceForstall
approved these changes
Sep 9, 2024
JulieLeeMSFT
approved these changes
Sep 10, 2024
JulieLeeMSFT
added
Servicing-approved
|
Seems there was infra issue. Rerunning the CI. |
|
@jeffschwMSFT @JulieLeeMSFT @carlossanlop - This is ready to merge. |
3 tasks
jeffschwMSFT
approved these changes
Sep 11, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107564 to release/9.0
/cc @kunalspathak
Customer Impact
We were using wrong base register to access the stack value leading to silent bad codegen failure. Although the issue was reported by fuzzlyn tool, it is likely that this can impact the functional behavior of a customer.
Regression
#38834 added the relevant assert that helped catch this issue, however the issue existed even before that.
Testing
Test case has been added and verified that it passes.
Risk
Low because it needs specific set of register requirements for linux/arm to hit the issue such that the stack offsets use different base register.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.