[release/9.0] [mono] Fix crash in emit_llvmonly_handler_start #107590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Do not try to emit branch when target_bb is not set
github-actions
bot
requested review from
fanyang-mono and
steveisok
as code owners
|
Tagging subscribers to this area: @lambdageek, @steveisok |
lambdageek
approved these changes
Sep 10, 2024
lewing
approved these changes
Sep 10, 2024
This was referenced Sep 11, 2024
|
@lewing can we get the template filled in? |
jeffschwMSFT
approved these changes
Sep 12, 2024
jeffschwMSFT
added
Servicing-approved
|
@lewing can you take a look at the PR failures? |
|
@lewing @radekdoulik today is the snap, please take a look at the PR failures |
|
/ba-g failures are known and tracked by BA it is only red because this is a release branch |
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107461 to release/9.0
/cc @lewing @radekdoulik
Customer Impact
Do not emit an llvm branch intruction when there is no target. This was never correct and in newer llvm versions it surfaces as a fatal error.
Regression
This existing error became fatal with new llvm versions.
Testing
Manual testing
Low, we avoid emitting incorrect code