-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WebAssembly nuget package references to RC1 SDK #107673
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
The only things failing are the wasm legs. @maraf, @ilonatommy, @lewing, @pavelsavara do the failures ring a bell? |
you should update all the versions in Versions.props that come from dotnet/runtime not just ilcompiler. the particular failure is because the ApiCompatTasksVersion is older than the runtime in the sdk |
dotnet/arcade#15071 will update global.json once it flows and you can use darc to properly update eng/Version.Details.xml with the runtime versions from the sdk |
We cannot do a proper update from dotnet/runtime. Last time it was attempted in #106873 and every single commit updating from dotnet/runtime was reverted. What's the targeted set of updates we need to fix wasm? The ILCompiler package update will go away once #107583 merges. I just put it here temporarily for testing. |
Sorry, was away from my computer before and thought this was 9.0. SdkVersionForWorkloadTesting has to be >= the sdk version in global.json. That is usually handled by flow from sdk back to runtime but can be problematic on framework transitions. |
I’m fine waiting for dotnet/arcade#15071 if it’s almost ready |
#107746 has the flow for 10 |
#107746 bumped the SDK to RC1 but it didn't contain the wasm nuget package updates so that is the only change left here. |
* Update to RC1 SDK * Update Versions.props * Update Versions.props * Update Versions.props --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Update to RC1 SDK * Update Versions.props * Update Versions.props * Update Versions.props --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
No description provided.