[ppc64le] Fixed BinaryFormatter and Tensors tests #107678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l method for ppc64le architecture
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
akoeplinger
approved these changes
Sep 11, 2024
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
added
area-Codegen-JIT-mono
and removed
needs-area-label
This was referenced Sep 11, 2024
Open
|
@alhad-deshpande CI is seeing an assertion on ppc64le: |
|
@akoeplinger [centos@temp-7 net9.0-linux]$ ../../../testhost/net9.0-linux-Release-ppc64le/dotnet exec --runtimeconfig System.Runtime.Serialization.Formatters.Tests.runtimeconfig.json --depsfile System.Runtime.Serialization.Formatters.Tests.deps.json xunit.console.dll System.Runtime.Serialization.Formatters.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing |
|
@alhad-deshpande I think the problem is the |
|
@akoeplinger |
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Note that we already branched for .net 9 a while ago so you'll need to carry this as a patch in your build. |
|
@akoeplinger Can we backport to .net 9 branch Should I raise a new PR for .net 9 branch? |
|
@alhad-deshpande s390x/ppc64le changes are not in scope for backporting, you can carry them as patches when you build the dotnet SDK for those platforms. /cc @uweigand |
|
@akoeplinger |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* [ppc64le] Fixed thunk address 8 byte alignment issue * Fixed FSharp crash issue * [ppc64le] Implementation of mono_arch_get_delegate_virtual_invoke_impl method for ppc64le architecture * Fixed clang15 build issues and returning address of sc_sp instead of value * Added float32 support and implemented related opcodes * Correction in OP_RCONV_TO_R cases * Corrected code for few opcodes * [ppc64le] performance improvements while branching * [ppc64le] Fixed insufficient memory exception issue * [ppc64le] Fixed BinaryFormatter and Tensors tests * Disable System.Runtime.Serialization.Formatters.Tests * Fix tests.proj --------- Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
4 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* [ppc64le] Fixed thunk address 8 byte alignment issue * Fixed FSharp crash issue * [ppc64le] Implementation of mono_arch_get_delegate_virtual_invoke_impl method for ppc64le architecture * Fixed clang15 build issues and returning address of sc_sp instead of value * Added float32 support and implemented related opcodes * Correction in OP_RCONV_TO_R cases * Corrected code for few opcodes * [ppc64le] performance improvements while branching * [ppc64le] Fixed insufficient memory exception issue * [ppc64le] Fixed BinaryFormatter and Tensors tests * Disable System.Runtime.Serialization.Formatters.Tests * Fix tests.proj --------- Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97296