-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NRBF] More bug fixes #107682
[NRBF] More bug fixes #107682
Commits on Sep 11, 2024
-
be explicit, always throw InvalidOperationException for values not ex…
…pected by switch statements and if/else blocks
Configuration menu - View commit details
-
Copy full SHA for 5543848 - Browse repository at this point
Copy the full SHA 5543848View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48283cd - Browse repository at this point
Copy the full SHA 48283cdView commit details -
reject all arrays with length > Arraym.MaxLength (not just uint.MaxVa…
…lue). This is something I agreed on with Jeremy Kuhne a while ago, but missed it.
Configuration menu - View commit details
-
Copy full SHA for 24166f5 - Browse repository at this point
Copy the full SHA 24166f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbaf39b - Browse repository at this point
Copy the full SHA bbaf39bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bb78e8 - Browse repository at this point
Copy the full SHA 8bb78e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for af07e22 - Browse repository at this point
Copy the full SHA af07e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 714b226 - Browse repository at this point
Copy the full SHA 714b226View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac40734 - Browse repository at this point
Copy the full SHA ac40734View commit details -
SerializationRecordId does not override ToString, we need to provide …
…the value of the Id in explicit way
Configuration menu - View commit details
-
Copy full SHA for 34f96bb - Browse repository at this point
Copy the full SHA 34f96bbView commit details -
provide DebuggerDisplay for SerializationRecordId, fix it for ArrayIn…
…fo (Length property is longer present in this type)
Configuration menu - View commit details
-
Copy full SHA for 9c8b0c6 - Browse repository at this point
Copy the full SHA 9c8b0c6View commit details -
throw SerializationException when PrimitiveType.String is provided in…
… a place where it's not valid
Configuration menu - View commit details
-
Copy full SHA for 2ff65c7 - Browse repository at this point
Copy the full SHA 2ff65c7View commit details -
revert a change that is going to get a fix in separate PR as it's not…
… complete, but increases the amount of code that needs to be reviewed
Configuration menu - View commit details
-
Copy full SHA for fdd59fc - Browse repository at this point
Copy the full SHA fdd59fcView commit details -
fuzzer: throw SerializationException when PrimitiveType.String is pro…
…vided in a place where it's not valid
Configuration menu - View commit details
-
Copy full SHA for 6fca7f3 - Browse repository at this point
Copy the full SHA 6fca7f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ff4f82 - Browse repository at this point
Copy the full SHA 4ff4f82View commit details
Commits on Sep 12, 2024
-
Remove "Null" and "String" from the internal enum PrimitiveType as it…
… is always illegal to parse it and every switch needed to take this into account. Now we reject those values at parse time and don't need to handle them later. - In case of BinaryArray (NRBF 2.4.3.1): "If the BinaryTypeEnum value is Primitive, the PrimitiveTypeEnumeration value in AdditionalTypeInfo MUST NOT be Null (17) or String (18)." - In case of MemberPrimitiveTyped (NRBF 2.5.1): "PrimitiveTypeEnum (1 byte): A PrimitiveTypeEnumeration value that specifies the Primitive Type of data that is being transmitted. This field MUST NOT contain a value of 17 (Null) or 18 (String)." - In case of ArraySinglePrimitive (NRBF 2.4.3.3): "A PrimitiveTypeEnumeration value that identifies the Primitive Type of the items of the Array. The value MUST NOT be 17 (Null) or 18 (String)." - In case of MemberTypeInfo (NRBF 2.3.1.2): "When the BinaryTypeEnum value is Primitive, the PrimitiveTypeEnumeration value in AdditionalInfo MUST NOT be Null (17) or String (18)."
Configuration menu - View commit details
-
Copy full SHA for 3aa1656 - Browse repository at this point
Copy the full SHA 3aa1656View commit details