[release/9.0] Move UseSystemZlib into SetupOSSpecificProps #107770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106566
Backport of #107666 to release/9.0
/cc @carlossanlop @hwoodiwiss
Customer Impact
Regression
The recent infrastructure refactoring that switched runtime from consuming zlib to consuming our in-tree copy of zlib-ng introduced a regression where native aot publishing was not possible anymore due to a misplaced msbuild property that would prevent detecting libz.so in the expected location.
Repro:
sudo apt remove zlib1g-dev
./dotnet-install.sh -v 9.0.100-rc.2.24462.22
dotnet new console -o naot
<PublishAot>true</PublishAot>
to the csprojdotnet publish naot.csproj
This error shows up:
Testing
/home/carlos/.nuget/packages/microsoft.dotnet.ilcompiler/9.0.0-rc.2.24459.11/build/Microsoft.NETCore.Native.Unix.targets
obj/
andbin/
folders.dotnet publish naot.csproj
again.Risk
Low: This affects the specific case of publishing with NativeAOT.