Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc updates for source-of-truth assemblies #107773

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Doc updates for source-of-truth assemblies #107773

merged 3 commits into from
Sep 13, 2024

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/dotnet-api-docs#9989.

@build-analysis build-analysis bot mentioned this pull request Sep 13, 2024
Open
carlossanlop
carlossanlop approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions for you to consider, but otherwise LGTM.

src/libraries/Microsoft.Extensions.Configuration.Json/src/JsonConfigurationSource.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Configuration/src/ChainedConfigurationProvider.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Configuration/src/ChainedConfigurationSource.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Configuration/src/StreamConfigurationSource.cs Outdated Show resolved Hide resolved
...libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/IKeyedServiceProvider.cs Outdated Show resolved Hide resolved
...braries/Microsoft.Extensions.DependencyInjection.Abstractions/src/IServiceProviderFactory.cs Outdated Show resolved Hide resolved
@carlossanlop carlossanlop added documentation Documentation bug or enhancement, does not impact product or test code area-Meta and removed area-Extensions-Configuration labels Sep 13, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member

Since these are APIs that belong to assemblies whose triple slash comments are the source of truth, we should consider backporting to the 9.0 branch. When this is ready, please add a comment here with the message:

/backport to release/9.0

And the bot will automatically create the backport for you.

@gewarren @carlossanlop
Apply suggestions from code review
0c11f34 
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
This was referenced Sep 13, 2024
Open
Open
Open
@gewarren
Copy link
Contributor Author

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10855453523

@gewarren gewarren merged commit fd9b86e into dotnet:main Sep 13, 2024
82 of 85 checks passed
@gewarren gewarren deleted the docs0912 branch September 13, 2024 20:09
@github-actions GitHub Actions
Copy link
Contributor

@gewarren an error occurred while backporting to release/9.0, please check the run log for details!

Error: @gewarren is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=gewarren

@gewarren
Copy link
Contributor Author

@carlossanlop Are you able to backport for me? See previous error.

@carlossanlop
Copy link
Member

carlossanlop commented Sep 13, 2024 •
edited
Loading

Needs a manual backport to resolve conflicts. Sure, I can do it for you.

Nevermind, the error says you don't have permission.

@carlossanlop
Copy link
Member

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10856682854

@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Merged
4 tasks
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@gewarren @jtschuster
Doc updates for source-of-truth assemblies (dotnet#107773)
ab6dfa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees

@gewarren gewarren

Labels
area-Meta documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @carlossanlop