[release/9.0] ARM64-SVE: Fix hwintrinsics flags #107802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
kunalspathak
added
the
Servicing-consider
|
@jeffschwMSFT PTAL |
jeffschwMSFT
approved these changes
Sep 13, 2024
jeffschwMSFT
added
Servicing-approved
amanasifkhalid
approved these changes
Sep 13, 2024
|
@amanasifkhalid @JulieLeeMSFT today is the snap, please take a look at the PR failures |
|
failure seems to be #107254 |
|
@jeffschwMSFT the test failure is #107254, which Build Analysis is tracking. Build Analysis isn't listing any unknown failures, so I don't know why it's red... |
|
/ba-g all failures are known |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107791 to release/9.0
/cc @kunalspathak @a74nh
Customer Impact
While refactoring some code in LSRA, we found that some of the flags on SVE intrinsics were incorrect. This could lead to asserts or worse functional correctness issues. We fixed this by fixing the flags.
Regression
The flags were added when the SVE intrinsics were implemented.
Testing
We have ran all the SVE tests (including stress tests).
Risk
Low: This only affects SVE area which is marked as
Experimental.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.