Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0-rc2] [release/9.0] BinaryFormatter tests improvements #107903

Merged
merged 7 commits into from
Sep 17, 2024
Merged

[release/9.0-rc2] [release/9.0] BinaryFormatter tests improvements #107903

merged 7 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. Remove package references from library tests (#106737) 

    * Remove package references from library tests

These tests should be referencing the product assemblies so that they
test latest and not old bits.

* Reference the OOB version of SRSF and make sure it's copied
    @ericstj
    ericstj authored and github-actions committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    173a7ff View commit details
    Browse the repository at this point in the history

  2. BinaryFormatter tests should be skipped only on AOT, WASM and Mobile (#… 

    …106858)

* respect AppContext switch (which is currently enabled for all projects in the root Directory.Build.props file)

* add project reference to all test projects that need working BF (and were being skipped for a while)

* adjust to changes from #104202: EqualityComparer<string>.Default is mapped to StringEqualityComparer, but serialized as GenericEqualityComparer<string>
    @adamsitnik
    adamsitnik authored and github-actions committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5f4f896 View commit details
    Browse the repository at this point in the history

  3. Don't use WeakReferences in the round trip test, as the target may ge… 

    …t freed in the meantime, fixes #104905 (#106967)
    @adamsitnik
    adamsitnik authored and github-actions committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    57c2918 View commit details
    Browse the repository at this point in the history

  4. Enable more BinaryFormatter tests (#107408) 

    * enable the BinaryFormatter tests in System.Runtime.Serialization.Formatters.Tests

* add new test project, where the flag is disabled and it runs only 3 tests in total that ensure that

* The SerializationGuard is no longer activated since BF was moved to the OOB package, the tests need to reflect that.
    @adamsitnik
    adamsitnik authored and github-actions committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    08e59d9 View commit details
    Browse the repository at this point in the history

  5. Disable binary formatter tests when DotNetBuildSourceOnly. (#107549)

    @tmds
    tmds authored and github-actions committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f40b07a View commit details
    Browse the repository at this point in the history

  6. [mono][tvos] Do not treat assembly.pdb/xml files as native files to b… 

    …undle when AOTing on Helix (#107079)

* Do not treat assembly.pdb/xml files as native files to bundle

* Bundle satellite assemblies as well
    @ivanpovazan
    ivanpovazan authored and github-actions committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6a7d6ca View commit details
    Browse the repository at this point in the history

  7. [mono][ci] Include PDBs from runtime pack when building on Helix if r… 

    …equired (#107348)
    @ivanpovazan
    ivanpovazan authored and github-actions committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d068714 View commit details
    Browse the repository at this point in the history