Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Root the System.Runtime EventSource #108348

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[release/9.0] Root the System.Runtime EventSource #108348

merged 2 commits into from
Sep 30, 2024

Commits on Sep 27, 2024

  1. Root the System.Runtime EventSource 

    The System.Runtime EventSource (RuntimeEventSource), was unintentionally being garbage collected because it wasn't rooted. This caused runtime EventCounters to no longer be available after GC occurred.

This was a regression from a recent change (#106014). That change accidentally converted the static field that was intended to the root the object into a property getter that returned a new instance each time it was called. This fix converts the property back into a statically initialized field.

This will fix #107919 once it is backported.
    @noahfalk
    noahfalk authored and github-actions committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    92a1495 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @noahfalk
    noahfalk authored and github-actions committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    12f0db9 View commit details
    Browse the repository at this point in the history