Use default timeout for launching the browser in WBT #108474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @directhex, @matouskozak |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
lewing
approved these changes
Oct 3, 2024
lambdageek
pushed a commit
to lambdageek/runtime
that referenced
this pull request
Oct 3, 2024
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 8, 2024
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11326064420 |
|
@ilonatommy backporting to release/9.0 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Use default timeout of 30s.
Using index info to reconstruct a base tree...
M src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Use default timeout of 30s.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@ilonatommy an error occurred while backporting to release/9.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #107771.
In the worst case launching the browser now will take 90 sec - we have 3 tries. It can prolong the execution of tests but it might also decrease the number of hits in the known issue till we find a real fix.
We always use
SpawnBrowserAsyncwith default parameter value:runtime/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/InterpPgoTests.cs
Line 54 in 3ca4ec8
and
runtime/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Line 157 in 3ca4ec8