[wasm] Fixes for issue #108519 #108543
[wasm] Fixes for issue #108519 #108543
Conversation
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
|
cc @pavelsavara |
|
this will need Net9 backport |
| @@ -1645,8 +1646,9 @@ get_queue (int queue) { | |||
| GPtrArray *result = NULL; | |||
| if ((result = (GPtrArray *)mono_native_tls_get_value (key)) == NULL) { | |||
| g_assert (mono_native_tls_set_value (key, result = g_ptr_array_new ())); | |||
| mono_os_mutex_lock (&queue_mutex); | |||
| // WARNING: Ensure we do not call into the runtime or JS while holding this mutex! | |||
There was a problem hiding this comment.
Just a tiny style comment. In the rest of the code this comment is after the mono_os_mutex_lock call.
p.s. For me this way is more clear...
|
/ba-g CI stuck |
* Fixes for issue 108519
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11231296080 |
|
@kg an error occurred while backporting to release/9.0, please check the run log for details! Error: @kg is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=kg |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11231378598 |
|
Thanks for the quick fix! |
Contributes to #108519