Remove uint casts in string.{Try}CopyTo
#108614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
EgorBo
reviewed
Oct 7, 2024
| @@ -432,14 +432,12 @@ public unsafe void CopyTo(int sourceIndex, char[] destination, int destinationIn | |||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
| public void CopyTo(Span<char> destination) | |||
| { | |||
| if ((uint)Length <= (uint)destination.Length) | |||
There was a problem hiding this comment.
can you revert to the previous order? because you see diffs from that and it doesn't allow to detect regressions from non-elided bound checks. The order shouldn't matter since PGO is going to reorder it its way anyway, also, the current order looks more efficient to me (rarely taken branches are moved down)
xtqqczze
changed the title
uint casts in string.(Try)CopyTouint casts in string.{Try}CopyTo
This was referenced Oct 7, 2024
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #67044