Fix GC stress log and analysis #108655
Open
Fix GC stress log and analysis #108655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markples
commented
Oct 8, 2024
markples
commented
Oct 8, 2024
| @@ -1299,6 +1295,7 @@ int ProcessStressLog(void* baseAddress, int argc, char* argv[]) | |||
| memset(&mapImageToStringId, 0, sizeof(mapImageToStringId)); | |||
| memset(s_interestingStringFilter, 0, sizeof(s_interestingStringFilter)); | |||
| memset(s_interestingStringMatchMode, 0, sizeof(s_interestingStringMatchMode)); | |||
| s_interestingStringMatchMode[IS_GCSTART] = true; | |||
There was a problem hiding this comment.
This is an unfortunate detail to have here, but I don't think we want to generalize the InterestingStrings table to have a prefix bool.
There was a problem hiding this comment.
This will be a little easier to do in the managed implementation I think.
This was referenced Oct 8, 2024
Open
markples
commented
Oct 8, 2024
markples
commented
Oct 8, 2024
…s 64-bit floating point values)
markples
force-pushed
the
stresslog-gcstart
branch
2 times, most recently
from
df9e20d
to
018d47c
Compare
3 tasks
|
"ILC: error IL1013: Error processing 'name'" is #108031 |
markples
changed the title
Closed
markples
commented
Oct 22, 2024
| // TRACE_GC has two sub-modes: the standard VM stress log mechanism and | ||
| // SIMPLE_DPRINTF, which is text output. By default, we enable TRACE_GC (not | ||
| // SIMPLE_DPRINTF) for debug/checked builds so that we can catch build breaks. | ||
| // HOST_64BIT is required because logging dprintf to the stress log us only |
markples
commented
Oct 22, 2024
| // time, which doesn't match usual stress log usage. | ||
| // | ||
| // In practice, dprintf(1) and LL_INFO10 (which has the value 4) have been used | ||
| // similarly on log messages. A dprintf(1) is generally called about once per |
Maoni0
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This includes multiple fixes to reenable the viewing of GC stress log events (from GC dprintf) in StressLogAnalyzer. It makes a small subset of the events available in all _DEBUG builds, which provides a build check in CI without overwhelming the stress log or runtime. This includes an audit of dprintf(1, ...) sites. More detailed GC stress logs can be enabled by changing the sources (as before).
Fixes to StressLogAnalyzer are least-effort because it is intended to be replaced by a C# version in #104999.
Details:
gcDetailedStartMsggcDetailedStartMsgto fit under the 16-argument limit for the stress log but keep all arguments forSIMPLE_DPRINTFIS_GCSTART%5sTRACE_GCTRACE_GCin_DEBUGbuildsIncludes #108089 until it is merged
Fixes #108628