[release/9.0] Initialize m_fInPlaceSS #109013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
A recent fix added a new field to the DebuggerPatchSkip object and missed initializing it false. This causes the new in-place patch skipping logic activate at random depending on the value of uninitialized memory. Fixing this by initializing the variable.
|
Tagging subscribers to this area: @tommcdon |
tommcdon
approved these changes
Oct 18, 2024
AaronRobinsonMSFT
approved these changes
Oct 18, 2024
hoyosjs
approved these changes
Oct 18, 2024
jeffschwMSFT
approved these changes
Oct 18, 2024
jeffschwMSFT
added
Servicing-consider
|
All failures seem to be #108994. |
This was referenced Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109008 to release/9.0
/cc @noahfalk
Customer Impact
When debugging a .NET app in Visual Studio or other managed debugger and continuing for a breakpoint or step, the debuggee application may crash with an ExecutionEngineException non-deterministically. The non-determinism comes from reading an uninitialized boolean. If it happens to be non-zero the runtime may execute some code that leads to a crash. The exact set of factors and code-flow that creates the crash is still under investigation but exploratory testing suggests crashes may occur relatively frequently if the uninitialized memory value happens to be non-zero.
Regression
#108872
Testing
So far the fix has only been code reviewed by me (Noah), and validated against our standard debugging tests. CI regression tests are in progress.
Risk
Very low - the fix initializes an uninitialized variable.