[release/8.0] fix redundant CRLF response during SMTP negotiate #109112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rzikm
changed the title
|
Thank you for considering backport 😄 |
No, the release process is more complicated and the code is branched off a month before the release. This code will likely ship in December servicing update. |
karelz
approved these changes
Nov 11, 2024
|
Migration blocker to .NET for important customer who needs LTS support. We should fix it in 8.0.x. |
karelz
added
Servicing-approved
|
Approved by @SteveMCarroll via email on 11/11. |
|
CI i s green. ready to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #105939 to release/8.0-staging.
Fixes #108382
/cc @rzikm @avin3sh
Customer Impact
Reported by a customer (financial institution) as migration blocker from .NET Framework to .NET Core LTS version. They need 8.0 LTS due to internal security restrictions.
The problem is with SMTP Negotiate authentication response, which is incorrect (reached via SmtpClient).
Regression
Yes - between .NET Framework and .NET Core.
It did not work on recent .NET Core releases. Possibly broken about 8 years ago when introducing Unix support.
Testing
Patch submitted and tested by customer - confirmed in #108382 (comment)
Risk
Low, the change is very contained and relevant code paths have been tested.