[release/8.0] Disable user mapper for SslStream on Windows (TLS 1.3) (#100833) #109116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
|
Did you forget the |
We only put that tag once the PR description has been finalized, there are some missing pieces waiting for @karelz's input. |
karelz
approved these changes
Nov 11, 2024
|
Large impact on few customers on LTS with regulatory impact. We should backport it to 8.0.x |
rzikm
added
Servicing-approved
|
Approved via email on 11/14 |
|
The CI failure is unrelated (System.Text.Json). ready to merge. |
|
/ba-g CI failure is unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #100833 to release/8.0-staging.
Fixes #108966, #100774
/cc @rzikm @avin3sh
Customer Impact
Reported by customer: From #108966 (comment)
The bug generates 12.1 millions of events in 24h period. They have to filter them out. The problem is that due to regulatory requirement they have to store them for a year, which requires large storage.
Note: Same fix for TLS 1.0-1.2 happened in .NET 8 (before GA): #80886 ... we just missed the branch for TLS 1.3.
Regression
No
Testing
CI tests pass.
Pending customer validation - unclear if it will happen in time.
Risk
Low, the change is small and affects only a specific scenario (Windows, SSL Server). The same change has been made in 9.0 few months ago for TLS 1.3 and there are no known issues. Similar fix happened in 8.0 (before GA) for TLS 1.0-1.2 (see #80886).