[mono] Use libclang from dotnet/llvm-project for offsets-tool.py #109188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the need for a system-installed libclang.
am11
reviewed
Oct 24, 2024
Comment on lines
+931
to
+934
| <_LibclangSuffix Condition="'$(HostOS)' == 'Windows'">.dll</_LibclangSuffix> | ||
| <_LibclangSuffix Condition="'$(HostOS)' == 'OSX'">.dylib</_LibclangSuffix> | ||
| <_LibclangSuffix Condition="'$(_LibclangSuffix)' == ''">.so</_LibclangSuffix> | ||
| <_LibclangPath>$(_LibclangPackageReferencePath)\tools\libclang$(_LibclangSuffix)</_LibclangPath> |
There was a problem hiding this comment.
Suggested change
| <_LibclangSuffix Condition="'$(HostOS)' == 'Windows'">.dll</_LibclangSuffix> | |
| <_LibclangSuffix Condition="'$(HostOS)' == 'OSX'">.dylib</_LibclangSuffix> | |
| <_LibclangSuffix Condition="'$(_LibclangSuffix)' == ''">.so</_LibclangSuffix> | |
| <_LibclangPath>$(_LibclangPackageReferencePath)\tools\libclang$(_LibclangSuffix)</_LibclangPath> | |
| <_LibclangPath>$(_LibclangPackageReferencePath)\tools\libclang$(LibSuffix)</_LibclangPath> |
(eng/native/naming.props is already included in all contexts)
There was a problem hiding this comment.
that doesn't work since we need the extension for the host OS where the offsets-generator runs during the build. naming.props is based off of PackageRID i.e. TargetOS
There was a problem hiding this comment.
ah, right, maybe we can create another set there completely based on host if this kind of thing has more than one usage (e.g. CG2 may also be doing similar shenanigans somewhere 😅).
This was referenced Oct 24, 2024
Open
|
/ba-g failures are unrelated to the offset-tool changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for a system-installed libclang.