Add support for building with Clang 19

[MichaelSimons]

Backport of #105141 to release/8.0
Upstreaming .NET 8.0 Fedora 41 patch

This is required so that source-build can build/test on Fedora 41 (dotnet/source-build#4593).

[am11]

LGTM. Thank you! 👍

[dotnet-policy-service]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

[omajid]

I forgot to note it down in my original Fedora patch, but the changes to src/native/libs/CMakeLists.txt are from a different PR: #101871

[omajid]

cc @dviererbe who had to use a similar fix on Ubuntu

[dviererbe]

cc @dviererbe who had to use a similar fix on Ubuntu

Correct, we have a patch for Ubuntu >= 24.10. Ubuntu 24.04 uses clang 18 and Ubuntu 22.04 uses clang 14 and therefore does not require the patch.

Nice that this gets backported :)

[dviererbe]

We also have a patch in place for clang 18. Shouldn't this be backported first before adding clang 19 support?

[MichaelSimons]

We also have a patch in place for clang 18. Shouldn't this be backported first before adding clang 19 support?

You should feel free to open a PR to upstream your patch. I'm not seeing a reason to order the changes.

[MichaelSimons]

@jkoritzinsky, what is the runtime's process for merging infra changes like this? Does this require tactics approval or tell mode?

[jkoritzinsky]

We usually do tell-mode for infra-only changes. I'm currently OOF, @hoyosjs can you help get this in?

[hoyosjs]

Is this release 8 only?

[hoyosjs]

Changing to staging branch seems to have messed this. I'll fix this tomorrow.

[am11]

Changing to staging branch seems to have messed this. I'll fix this tomorrow.

Usually infra (build related) changes are directly pushed to the release branch (#107921), while product changes go through staging. It's a bit confusing where we draw the line.

[hoyosjs]

That's usually only true if there's an undergoing release build and the error is seen after merge of staging, since there won't be more merges. That PR you mention was retargeted to the staging branch.

[jeffschwMSFT]

approved. we can take this as tell mode

cc @carlossanlop

[MichaelSimons]

Can someone help get this merged in? Source-build CI needs this fix.

[jkoritzinsky]

/ba-g Failures are unrelated