Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Stopwatch.GetElapsedTime for rate limiter #109213

Merged
merged 11 commits into from
Nov 8, 2024
Merged

use Stopwatch.GetElapsedTime for rate limiter #109213

merged 11 commits into from
Nov 8, 2024

Conversation

WeihanLi
Copy link
Contributor

use Stopwatch.GetElapsedTime to simplify IdleDuration for rate limiter

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 25, 2024
This was referenced Oct 25, 2024
Open
Open
@WeihanLi WeihanLi marked this pull request as ready for review October 25, 2024 14:13
@tannergooding
Copy link
Member

LGTM, but should get a secondary sign-off before merge.

stephentoub
stephentoub approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This was referenced Nov 8, 2024
Open
Open
Open
@stephentoub stephentoub merged commit b567474 into dotnet:main Nov 8, 2024
79 of 83 checks passed
@WeihanLi WeihanLi deleted the rate-limiter branch November 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@martincostello martincostello Awaiting requested review from martincostello

@tannergooding tannergooding Awaiting requested review from tannergooding

Assignees
No one assigned
Labels
area-System.Threading community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WeihanLi @tannergooding @martincostello @stephentoub