Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix some typos #109259

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Chore: fix some typos #109259

merged 2 commits into from
Oct 29, 2024

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Oct 27, 2024

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 27, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@c8ef
Copy link
Contributor Author

c8ef commented Oct 27, 2024

@dotnet-policy-service agree

@jkotas jkotas closed this Oct 27, 2024
@jkotas jkotas reopened this Oct 27, 2024
@xtqqczze
Copy link
Contributor

  • explictly -> explicitly
  • explictely -> explicitly
  • explict -> explict

@xtqqczze
Copy link
Contributor

Confirmed 978d23a fixes all 6 occurrences of typo explict in the repository:

src/coreclr/gc/gc.cpp:    // below (unless its configured explictly) such that there are at least 2 regions available
src/libraries/System.ComponentModel.TypeConverter/tests/RegisteredTypesTests.cs:                // Even though C1.Class.Base is not explictely registered, we should still be able to get the properties of Base.
src/libraries/System.ComponentModel.TypeConverter/tests/RegisteredTypesTests.cs:                // Even though C1.Class.Base is not explictely registered, we should still be able to get the properties of Base.
src/libraries/System.Net.Http/src/System/Net/Http/DiagnosticsHelper.cs:#pragma warning disable CA1859 // we explictly box here
src/tests/Loader/classloader/SequentialLayout/ManagedSequential/LargeStructSize_CoreCLR.cs:    struct Y_explict
src/tests/Loader/classloader/SequentialLayout/ManagedSequential/LargeStructSize_CoreCLR.cs:            Assert.Throws<TypeLoadException>(() => sizeof(Y_explict));

@jkotas
Copy link
Member

jkotas commented Oct 27, 2024

/azp run runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants