-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] Automate dl 9 0 #109291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lewing - Please retarget this PR to the release/9.0-staging branch.
You can retarget to that branch by clicking on the Edit button on the top right (next to the PR title) and choosing the release/9.0-staging branch from the dropdown. Important: Please make sure you don't bring any unrelated changes from the release/9.0 branch when retargeting to release/9.0-staging.
@@ -7,7 +7,7 @@ | |||
<MinorVersion>0</MinorVersion> | |||
<PatchVersion>0</PatchVersion> | |||
<SdkBandVersion>9.0.100</SdkBandVersion> | |||
<PackageVersionNet8>8.0.11</PackageVersionNet8> | |||
<PackageVersionNet8>8.0.$([MSBuild]::Add($([System.Version]::Parse('$(ProductVersion)').Build),11))</PackageVersionNet8> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want PatchVersion here and not ProductVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It parses the ProductVersion, at least in 8.0 that also changed? Is there some reason it is still 9.0.0 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, I just saw the productversion and didn't notice the parse. Does parsing that and grabbing build do the right thing? I actually don't know.
We'll merge the other one instead of this one: #110586 |
No description provided.