Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Fix Version.Details.xml SHA typo #109389

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Oct 30, 2024

The last time this SHA was modified, was in June 2023, where it was manually modified with a typo at the end (extra b, leftover from writing over the previous commit SHA which ended in a b too).

The darc subscription for System.CommandLine is turned off in the release/8.0 and staging branches, so it makes sense that it has not been updated since then.

The correct SHA is the same that is consumed by the Dependency entry above this one:

<Sha>02fe27cd6a9b001c8feb7938e6ef4b3799745759</Sha>

@vseanreesermsft noticed this when running a script that was unable to find a build that matched this commit.

@carlossanlop carlossanlop requested review from vseanreesermsft and a team October 30, 2024 20:59
@carlossanlop carlossanlop self-assigned this Oct 30, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copy link

@vseanreesermsft vseanreesermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop carlossanlop merged commit 2c4c6f5 into dotnet:release/8.0-staging Nov 4, 2024
23 checks passed
@carlossanlop carlossanlop deleted the FixSha branch November 4, 2024 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants