[release/8.0-staging] [android] Fix crash in method_to_ir #109511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There exists a possibility where the klass being passed to try_prepare_objaddr_callvirt_optimization is not legit. This can result in unpredictable crashes. To fix, we pass the MonoType and flush out the MonoClass by calling mono_class_from_mono_type_internal. Fixes #109111
github-actions
bot
requested review from
lambdageek and
SamMonoRT
as code owners
|
Tagging subscribers to this area: @lambdageek, @steveisok |
This was referenced Nov 4, 2024
lambdageek
approved these changes
Nov 5, 2024
jeffschwMSFT
approved these changes
Nov 5, 2024
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #109381 to release/8.0-staging
/cc @steveisok
Customer Impact
A customer was experiencing intermittent crashes with their android app around
mono_method_to_ir. After testing multiple iterations, we found there were times when calls totry_prepare_objaddr_callvirt_optimizationcontained a null reference to a MonoClass. As a result, the app would crash.To fix, we made a call to
mono_class_from_mono_type_internalto make sure we would get a legit MonoClass.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manual before and after. After app did not crash.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.