Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MailAddress accepts invalid email address with consecutive dots #109690

Merged
merged 2 commits into from
Nov 21, 2024
Merged

MailAddress accepts invalid email address with consecutive dots #109690

merged 2 commits into from
Nov 21, 2024

Conversation

pedrobsaila
Copy link
Contributor

Fixes #109590

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 10, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 11, 2024
Open
ManickaP
ManickaP approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Please also change the comment above the class:

runtime/src/libraries/System.Net.Mail/src/System/Net/Mail/DotAtomReader.cs

Lines 14 to 15 in 35d2780

// or end, but we do allow dots at the end for compatibility with other mail clients. We also allow
// multiple consecutive dots, which would normally be invalid.

And we need to change the docs as well as they explicitly mention allowing double dots:
https://learn.microsoft.com/dotnet/api/system.net.mail.mailaddress#remarks

@build-analysis build-analysis bot mentioned this pull request Nov 11, 2024
Open
3 tasks
@ManickaP ManickaP merged commit 0d55c5b into dotnet:main Nov 21, 2024
81 of 83 checks passed
@pedrobsaila pedrobsaila deleted the 109590 branch November 22, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManickaP ManickaP ManickaP approved these changes

Assignees
No one assigned
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MailAddress accepts invalid email address with consecutive dots
2 participants
@pedrobsaila @ManickaP