Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put brotli on the FetchContent plan (Try 2) #109707

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Put brotli on the FetchContent plan (Try 2) #109707

wants to merge 6 commits into from

Commits on Nov 11, 2024

  1. Reapply "Put brotli on the FetchContent plan (dotnet#107166)" (dotnet… 

    …#109108)

This reverts commit b780069.
    @jkoritzinsky
    jkoritzinsky committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    88b2cf0 View commit details
    Browse the repository at this point in the history

  2. Don't double-install the brotli libs

    @jkoritzinsky
    jkoritzinsky committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    97c0d26 View commit details
    Browse the repository at this point in the history

  3. Don't try looking up locations for system brotli. Rely on the distro … 

    …maintainer to set the paths correctly.

Fixes dotnet#109105
    @jkoritzinsky
    jkoritzinsky committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    dc47509 View commit details
    Browse the repository at this point in the history

  4. Install brotli where we install the compression native lib so they're… 

    … always side-by-side (and we don't need to add it to the Mono build)
    @jkoritzinsky
    jkoritzinsky committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fd394f7 View commit details
    Browse the repository at this point in the history

  5. Brotli should get pulled from the same place as Compression.Native

    @jkoritzinsky
    jkoritzinsky committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4afff60 View commit details
    Browse the repository at this point in the history

  6. Fix looking for libbrotlicommon.a on disk to determine if we should u… 

    …se system brotli
    @jkoritzinsky
    jkoritzinsky committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e3748a0 View commit details
    Browse the repository at this point in the history